Skip to content

Conversation

@tjohnson31415
Copy link
Collaborator

@tjohnson31415 tjohnson31415 commented May 30, 2025

Most of the env vars can be handled automatically in the Sentient backend now, but it seems that flex requires torchrun style RANK and WORLD_SIZE env vars for configuring distributed serving.

Credit to @tdoublep for the insight of setting RANK and WORLD_SIZE for flex.

@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Signed-off-by: Travis Johnson <[email protected]>
@tjohnson31415
Copy link
Collaborator Author

The test failure with CB is due to another upstream change to the step() API, unrelated to the changes in this PR.

Copy link
Member

@tdoublep tdoublep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice cleanup, and great that we have a fix for the TP issue.

@tdoublep tdoublep merged commit 216409c into main Jun 1, 2025
20 of 21 checks passed
@tdoublep tdoublep deleted the fix-spyre-setup branch June 1, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants